and  what I mean is

/*
==================
ReQWave Shotgun Spread
Thanks Phoenix Gen Arena
This should match CG_ShotgunPattern
==================
*/
void ShotgunPattern( vec3_t origin, vec3_t origin2, int seed, gentity_t *ent ) {
   int         i;
   float      r, u;
   vec3_t      end;
   vec3_t      forward, right, up;
   int         oldScore;
   qboolean   hitClient = qfalse;

        float range;  // How far away from center we're placing our pellets.
        int interval;  // How many times we're incrementing.
        float deg;  // How many degrees we're rotating by.  This should be half the total count.

        interval = DEFAULT_SHOTGUN_COUNT;
        if (interval <= 0){   // I always sanity check for divide by zero when doing a divide by any variable.
                interval = 16;
        }
        deg = 360 / 0.5f * interval;

// derive the right and up vectors from the forward vector, because
   // the client won't have any other information
   VectorNormalize2( origin2, forward );
   PerpendicularVector( right, forward );
   CrossProduct( forward, right, up );

   oldScore = ent->client->ps.persistant[PERS_SCORE];

   // generate the "random" spread pattern
   for ( i = 0 ; i < interval ; i++ ) {

      r = sin(DEG2RAD( (0.5f * deg) + (deg * i)) );
      u = cos(DEG2RAD( (0.5f * deg ) + (deg * i)) );

      if (i < interval * 0.5){
         range = 0.5f * DEFAULT_SHOTGUN_SPREAD;
       } else {
         range = DEFAULT_SHOTGUN_SPREAD;
      }

      r *= range * 16;
      u *= range * 16;

      VectorMA( origin, 8192 *16, forward, end);
      VectorMA (end, r, right, end);
      VectorMA (end, u, up, end);
      if( ShotgunPellet( origin, end, ent ) && !hitClient ) {
         hitClient = qtrue;
         ent->client->accuracy_hits++;
      }
   }
}



/*
================
CG_ShotgunPattern
ReQWave Thanks Phoenix Gen Arena
Perform the same traces the server did to locate the
hit splashes
================
*/
static void CG_ShotgunPattern( vec3_t origin, vec3_t origin2, int seed, int otherEntNum ) {
   int         i;
   float      r, u;
   vec3_t      end;
   vec3_t      forward, right, up;

        float range;  // How far away from center we're placing our pellets.
        int interval;  // How many times we're incrementing.
        float deg;  // How many degrees we're rotating by.  This should be half the total count.

        interval = DEFAULT_SHOTGUN_COUNT;
        if (interval <= 0){   // I always sanity check for divide by zero when doing a divide by any variable.
                interval = 16;
        }
        deg = 360 / 0.5f * interval;

// derive the right and up vectors from the forward vector, because
   // the client won't have any other information
   VectorNormalize2( origin2, forward );
   PerpendicularVector( right, forward );
   CrossProduct( forward, right, up );

   // generate the "random" spread pattern
   for ( i = 0 ; i < interval ; i++ ) {

      r = sin(DEG2RAD( (0.5f * deg) + (deg * i)) );
      u = cos(DEG2RAD( (0.5f * deg ) + (deg * i)) );

      if (i < interval * 0.5){
         range = 0.5f * DEFAULT_SHOTGUN_SPREAD;
       } else {
         range = DEFAULT_SHOTGUN_SPREAD;
      }

      r *= range * 16;
      u *= range * 16;

      VectorMA( origin, 8192 *16, forward, end);
      VectorMA (end, r, right, end);
      VectorMA (end, u, up, end);

      CG_ShotgunPellet( origin, end, otherEntNum );
   }
}



bg_public.h

#define DEFAULT_SHOTGUN_SPREAD   700
#define DEFAULT_SHOTGUN_COUNT   16 (i tried 20 first)

Oh I'm sorry... No it's still drawing only 2 pellets.

Hmmm... Just an FYI I have been using a ioq3 based source. And I noticed team stats mod doesn't work. It won't show the armor or health of the teammates.

Another coding friend said this.

I don't know if this may help with the shotgun pattern at all but because of changes like this I maybe changing my base source...

PEMDAS

Haha
I'll let you know how it works

Now the pellets don't flip around the center of the screen but it's still only two.

Derp.... And after I picked at you about order of operations...

Lmfao

In an interesting turn of events the pattern works great but shotgun does no damage,

I tried to change the default shotgun damage from 10 to 5.5. i though that if that was a decimal maybe it was wrong. so i changed it to a whole number. 6 and still had no damage. i changed it to 10 and still had no damage. i scaned over the modifications too the code and best i can tell the code is sound. so what actually causes the shotgun damage?


this part looks the same between the orig and the mod
    if (ShotgunPellet(origin, end, ent) && !hitClient)
     {
       hitClient = qtrue;
       ent->client->accuracy_hits++;
     }

I dont know why it wouldnt work. maybe im looking in the wrong spot

Ahh, I found the problem.  It's a leftover gib from the crossproduct stuff in ShotgunPattern.  Remark out the line I've noted below:


The forward, right, and up vectors here are local to the function, but at the very beginning of g_weapon.c you'll see the same variable names as static vec3_t.  Static vars are "global" vars within that file that retain their data between functions, as opposed to local vars within the function that are not accessible to other functions unless passed in an argument.  The static vars are derived from the player's view angles in FireWeaon.  Using the same variable names for both global and local variables is BAD PROGRAMMING TECHNIQUE!!!  BAD DUFFY!!  BAD, BAD DUFFY!!  SHAME ON YOU!!! 

So remark that line out and the damage traces will work properly.  Do NOT remark the line out in CG_ShotgunPattern because the ones used there are local;  there's no static versions in that file so CG_ShotgunPattern is coded properly.